Skip to content

docs: update rrf retriever default rank_window_size #130930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2025
Merged

docs: update rrf retriever default rank_window_size #130930

merged 3 commits into from
Jul 11, 2025

Conversation

mromaios
Copy link
Contributor

@mromaios mromaios commented Jul 9, 2025

This PR updates the default rank_window_size parameter for the rrf retriever from size to 10.

@mromaios mromaios added >docs General docs changes :SearchOrg/Relevance Label for the Search (solution/org) Relevance team labels Jul 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Documentation preview:

@mromaios mromaios self-assigned this Jul 9, 2025
@mromaios mromaios marked this pull request as ready for review July 9, 2025 15:03
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:SearchOrg Meta label for the Search Org (Enterprise Search) Team:Search - Relevance The Search organization Search Relevance team labels Jul 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@mromaios mromaios requested review from Mikep86 and kderusso July 10, 2025 09:22
kderusso
kderusso approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this need an 8.19 PR too?

Mikep86
Mikep86 approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @kderusso I'm already handling this update in 8.19 here: #130842

@mromaios mromaios merged commit d83a657 into elastic:8.18 Jul 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikep86 Mikep86 Mikep86 approved these changes

@kderusso kderusso kderusso approved these changes

Assignees

@mromaios mromaios

Labels
>docs General docs changes :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Docs Meta label for docs team Team:Search - Relevance The Search organization Search Relevance team Team:SearchOrg Meta label for the Search Org (Enterprise Search) v8.18.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mromaios @elasticsearchmachine @Mikep86 @kderusso